Repository navigation
fix: make Sodium optional with new fabric loader, and make no fog and Voxy work together - #347
Merged
Merged
Conversation
Fabric Loader 0.19.4+ makes missing mixin targets fatal, which hits lambda-loader installs now, and everyone once the loader gets bumped. Skip the Sodium and Indigo mixins when they aren't installed.
Voxy stops drawing LODs when the fog ends inside the render distance, and the zeros put it at 0. Push the distances out to Float.MAX_VALUE instead. Alpha's still 0, so there's no fog either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Startup without Sodium: Fabric Loader 0.19.4+ fails on missing mixin targets instead of warning (FabricMC/Mixin#231), effectively making Sodium required. Added a mixin plugin to skip Sodium and Indigo mixins when unavailable (Indigo is included in Fabric API 0.140+).
No Terrain Fog with Voxy: Changed Sodium's fog distances from 0 to Float.MAX_VALUE, keeping fog invisible while preventing Voxy from hiding LODs.
Notes
Right now this only affects lambda-loader installs, but #345 bumps the Loader, so it'll apply to every install, dev included. Ideally merge #345 first, then I'll remove the unnecessary Indigo check and plugin boilerplate before merging this PR.
Used a mixin plugin rather than a separate non-required config so the config stays required, and broken Sodium mixins still fail instead of being skipped with just a warning.